Page 3 of 5
Re: Need help find a working piano module...
Posted: Sun Feb 23, 2014 6:00 pm
by Nubeat7
there is a note off triggerconnection from mouseLup which produces a 2nd note off trigger, the note offtrigger is already done by mousedrag which sends a bool to off when release the mousebutton..
don`t know if this also fixes the disappearing gui bug..

- keyboard_noteofftrigger.png (154.26 KiB) Viewed 18002 times
Re: Need help find a working piano module...
Posted: Sun Feb 23, 2014 8:05 pm
by Jay
good find!
im experiencing some real problems with my midi atm, my rig is not outputing any note off messages, nomatter whether i input midi through my Tascam interface or hook keyboards/synths straight to usb! it is instead giving me a secondary note on with a velocity of 0. bizzare! it seems to have started doing this since i installed a virtual rack software called V-Raxtor, might not be the culprit but its getting the blame ha ha
so i have to use the old M-Audio fix to acheive note off, whitch brings me to this - the MAudio fix is wired incorrectly inside this keyboard module!
Wrong

- wrong.png (6.87 KiB) Viewed 17996 times
Correct

- right.png (6.78 KiB) Viewed 17996 times
another thing i have noticed is that pressed keys on the GUI keyboard are transparent so there appears to be something wrong with its animation. is anyone else seeing this too?
regards
Re: Need help find a working piano module...
Posted: Sun Feb 23, 2014 11:31 pm
by Nubeat7
yes its transparent, someone modified it like this.. in the white key draw part there should be a selector which reacts by note on bool and changes colors between white and ivory.. but you also could just underlay a rectangle with keyboard size and the preferred color, which i think was the plan of the mod..

- keycolors.png (97.37 KiB) Viewed 17991 times
about the note off message works fine here also without the m-audio mod, anyway in the incoming notes module the note off trigger is also sent when data 2 is zero
Re: Need help find a working piano module...
Posted: Mon Feb 24, 2014 11:32 am
by djbrynte
another thing i have noticed is that pressed keys on the GUI keyboard are transparent so there appears to be something wrong with its animation. is anyone else seeing this too?
Yes i have seen it

Re: Need help find a working piano module...
Posted: Mon Feb 24, 2014 11:51 am
by Nubeat7
djbrynte wrote:Yes i have seen it
watch my last post for the fix!
is the last fsm with oddsons keyboard where i fixed the double note off trigger bug free now?
because i cannot reproduce the gui bug...
Re: Need help find a working piano module...
Posted: Mon Feb 24, 2014 6:36 pm
by djbrynte
What ever this will prob never gets fixed.
Re: Need help find a working piano module...
Posted: Mon Feb 24, 2014 7:49 pm
by kortezzzz
What ever this will prob never gets fixed.
I believe it can be done by separating the graphics module from the midi\green system.
GREAT JOB, NUBEAT7 !

, the double-trigger problem is behind us. now, lets try to take
care of the keyboard's "houdini syndrome" and get rid of the slow-downs (when playing an external keyboard with
both hands) and the high CPU.
i'll try to fix it tonight.

Re: Need help find a working piano module...
Posted: Tue Feb 25, 2014 12:09 am
by Nubeat7
kortezzzz wrote:get rid of the slow-downs (when playing an external keyboard with
both hands) and the high CPU.
oh good to remind me, this also should be fixed or better now because i integrated a redraw limiterbefore the noteOn boolean which sets the graphical keys to on / off when played by external midi, so the excessive cpu on fast externalmidi notes should be much better too, totally forgot about this...
maybe you could have a look if i`m right?
Re: Need help find a working piano module...
Posted: Tue Feb 25, 2014 12:41 am
by Nubeat7
in which cases does parts of the gui disappear, i cannot reproduce it?
Re: Need help find a working piano module...
Posted: Tue Feb 25, 2014 2:46 am
by Jay
yup i also saw the audio slowdowns when playing with both hands!
this keyboard was a result of two main creators of whome none of them were keyboard players enought to have the ability to play 2 handed and at any sort of pace! they were however both very great pioneers of Synthmaker and were more compitent in dsp
when this was made synthmaker was a relativly new thing all together!(pre-cursor to flowstone for anyone who does not know the history of the app) that prolly explains a bit about why the slow audio shit was not noticed and sorted out!
BTW this keyboard is quite ancient on that timeline! there are other working ones that look better so what is the facination of trying to fix this one? im puzzeled!
the vanishing act can flip beween partal vanishing (certain keys or octaves)to fully vanishing for no apparent reason, i seam to recall adding other graphical elements triggered the crash! but then we are talking 5-6 years ago!